feat: add version deps command [modversion] #6115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kubuxu
commented
Mar 21, 2019
•
Kubuxu
commented
- Tests
ghost
assigned
Kubuxu
commented
Mar 21, 2019
| return nil | ||
| }, | ||
| Encoders: cmds.EncoderMap{ | ||
| cmds.Text: cmds.MakeTypedEncoder(func(req *cmds.Request, w io.Writer, dep Dependency) error { |
There was a problem hiding this comment.
For some reason, if I change Dependency to *Dependency here I get no output, no error and the encoder is not being run (tested with panic).
|
@Stebalien this requires us to bump to Go1.12, is that ok? |
Stebalien
requested changes
Mar 21, 2019
| return nil | ||
| }, | ||
| Encoders: cmds.EncoderMap{ | ||
| cmds.Text: cmds.MakeTypedEncoder(func(req *cmds.Request, w io.Writer, dep Dependency) error { |
core/commands/version.go
Outdated
| fmt.Fprintf(w, " => %s", dep.ReplacedBy) | ||
| } | ||
| fmt.Fprintf(w, "\n") | ||
| return errors.New("test") |
There was a problem hiding this comment.
Seems like this error gets ignored. Interesting.
There was a problem hiding this comment.
diff --git a/core/commands/version.go b/core/commands/version.go
index 9c5c666d0..c9632f799 100644
--- a/core/commands/version.go
+++ b/core/commands/version.go
@@ -118,9 +118,13 @@ Print out all dependencies and their versions.`,
}
return
}
- res.Emit(toDependency(&info.Main))
+ if err := res.Emit(toDependency(&info.Main)); err != nil {
+ return err
+ }
for _, dep := range info.Deps {
- res.Emit(toDependency(dep))
+ if err := res.Emit(toDependency(dep)); err != nil {
+ return err
+ }
}
return nil
},
|
@Kubuxu personally, I'm fine with a go 1.12 bump. Non-buggy go modules require that as well. Other comment: needs test. |
Stebalien
requested changes
Mar 21, 2019
core/commands/version.go
Outdated
| fmt.Fprintf(w, " => %s", dep.ReplacedBy) | ||
| } | ||
| fmt.Fprintf(w, "\n") | ||
| return errors.New("test") |
There was a problem hiding this comment.
diff --git a/core/commands/version.go b/core/commands/version.go
index 9c5c666d0..c9632f799 100644
--- a/core/commands/version.go
+++ b/core/commands/version.go
@@ -118,9 +118,13 @@ Print out all dependencies and their versions.`,
}
return
}
- res.Emit(toDependency(&info.Main))
+ if err := res.Emit(toDependency(&info.Main)); err != nil {
+ return err
+ }
for _, dep := range info.Deps {
- res.Emit(toDependency(dep))
+ if err := res.Emit(toDependency(dep)); err != nil {
+ return err
+ }
}
return nil
},
|
@Kubuxu we'll also need to update the go version in CI. |
|
I know, just didn't have time to handle it today. |
Kubuxu
changed the title
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
This is ready. |
Stebalien
reviewed
Apr 4, 2019
Stebalien
approved these changes
Apr 4, 2019
|
Wait with it, I've done something weird in sharness. |
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
|
I think it is done. |
|
It is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.