[WIP] Unixfs: enforce refs on files when using nocopy #5925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Jan 14, 2019
magik6k
force-pushed
the
fix/nocopy-errors
branch
from
e679abe to
bdcef02
Compare
magik6k
changed the title
|
Looks like due to ipfs/go-mfs#38, running mfs related commands locally is racy: $ alias tipfs='IPFS_PATH=/tmp/ipfs ipfs'
$ tipfs init --profile=test -b=1024
$ tipfs files mkdir /cats
$ tipfs files ls
$ # no cats :( (about 70% of the time, if there are, rm /tmp/ipfs and start over)(This PR works fine without ipfs/go-mfs#38) |
|
Sorry for that, small typo, we really need to add tests for the republisher. Pushed it as a hotfix in v0.1.31 (ipfs/go-mfs@2e0c3bc). |
schomatis
removed
the
status/blocked
magik6k
force-pushed
the
fix/nocopy-errors
branch
from
bdcef02 to
7dbadd0
Compare
|
Thanks for catching that! (yeah, we need better tests) |
|
There are still some errors in |
|
I'm fairly confident that it's not related to these changes, the missing CID is |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
Stebalien
force-pushed
the
fix/nocopy-errors
branch
from
7dbadd0 to
12e1379
Compare
|
Yeah, it looks like there's a regression in go-mfs due to that WaitPub PR. And ipfs/go-blockservice#15 dosn't fix it. |
Merged
|
Dammit github! Replaced by #5937 (github wouldn't let me reopen this after I rebased). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4558
Depends on: