disable building with go1.10 for release

[whyrusleeping]

Something in go1.10 breaks ipfs in some way. This prevents people from building the release on their own and complaining when things break. We will remove this as soon as the 0.4.15 cycle starts.

License: MIT
Signed-off-by: Jeromy [email protected]

[Kubuxu]

Our whole CI uses Go1.10...

[victorb]

Our whole CI uses Go1.10...

We can have Jenkins build both go1.9 and go1.10 for you if you want? Easier to track progress

[Kubuxu]

@victorbjelkholm unfortunately for some reason the problems are not showing up in our tests.

So for time being building with Go 1.10 won't help much.

[Kubuxu]

looks like jenkins is running 1.9

[Kubuxu]

@whyrusleeping looks like that build tag didin't work

[whyrusleeping]

@Kubuxu it looks like it did work. All the tests failed

[Kubuxu]

Yes but Jenkins is using Go 1.9 on master. Otherwise we would have noticed long time ago as there was one more test failing apart from one I've added in #4790

[victorb]

unfortunately for some reason the problems are not showing up in our tests

As I understand, the issue applies to very basic usage of get, which should surely be caught in your tests? (at least as I understand #4781). If this issue only happens with 1.10 and not with 1.9, tests would be passing on 1.9 and with this fix, not be runnable at all on 1.10 and with the other fixes (#4793) should be passing.

[Kubuxu]

@victorbjelkholm in short terms yes.

[Kubuxu]

@victorbjelkholm main fix is #4790 the #4793 is fixing the patter in other places across the codebase but as far as we know nothing else is broken.

The bug arose because of bad usage of Read on our side and changes Golang made to tar standard library in Go 1.10.