-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Jenkinsfile #4430
Create Jenkinsfile #4430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO go-ipfs should get a custom pipeline. The problem here is that sharness is not included in make test
task, and it doens't run on windows (does it?). Currently go tests/sharness are run as separate tasks in parallel:
Well, if it absolutely have to, sure. But we should try to make testing across all repositories as similar as possible. This makes it easier to write a generic pipeline that we can reuse, and it'll also help people to get started to develop when they are new, since once you learned how one repo works, it'll be similar.
I can see activating sharness tests could be a config option in the
With this new Jenkinsfile, it does test on macOS, Linux and Windows. |
@victorbjelkholm go-ipfs is quite a special flower here. Tests, Makefiles and coverage collection are at least an order of magnitude more complex than rest of our projects. In future we might need similar complexity for other repos but I think it might be more worthwhile right now to just make it work with custom pipeline (including the different distros). Any way we can for time being have both builds, the old pipeline and the new one? |
c66ec79
to
8b20c84
Compare
Missing to finish:
macOS failures:
windows failures:
Full build: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-4430/21/pipeline/8 |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
Pushed some fixes for windows tests in #4632. To fix the fuse errors you need to add
|
@magik6k as I understand the blocker here is on propagating go-libp2p-peer, right? |
Yep, that's the only thing blocking this for now |
Closing in favor of #4530 |
Got them cross-platform tests for go-ipfs here. Pipeline is here (will move to IPFS org) https://github.com/VictorBjelkholm/jenkins-libs/blob/master/vars/golang.groovy
Still have some refactoring to do with the pipeline and figure out if to skip fuse tests or install fuse on all workers. Thoughts?