fix(libp2p): streams config validation in resource manager #10435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like when configuring custom resource manager limits, the node fails to start with an error:
With this fix the node starts - same if condition exists a few lines above for
rcm.System.ConnsInbound
andrcm.System.Conns
.How to reproduce
Configure
ConnectionManager
:and enable
ResourceManager
:and configure some resource limits, especially streams:
Current behavior
Launching the
ipfs daemon
fails:Expected behavior
ipfs daemon
launches with configured limits without an error.