Align systemd unit file with the default IPFS installation path #10163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Install script, cmd/ipfs/dist/README.md doc, and also Docker file sugget that default install path for ipfs binary will be in: /usr/local/bin/ipfs but systemd file was pointing to /usr/bin/ipfs. This patch is making systemd unit file to comform to the rest.
Jorropo
approved these changes
Oct 5, 2023
Jorropo
pushed a commit
that referenced
this pull request
Oct 5, 2023
) (cherry picked from commit 6dbae76)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation (cmd/ipfs/dist/README.md), installation scripts, and Docker files all indicate that the default installation path for the IPFS binary is /usr/local/bin/ipfs. Moreover, following the official installation guide here also places the binary in /usr/local/bin/.
However, the systemd service files reference a different path (/usr/bin/ipfs), which can lead to inconsistencies and potential operational issues.
This PR adjusts the systemd unit files to align with the predominant and documented installation path, ensuring consistency and reliability for users following the official guidelines.