Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing content path when dir listing on subdomain or DNSLink gw #7205

Closed
lidel opened this issue Apr 23, 2020 · 2 comments · Fixed by #7219
Closed

Missing content path when dir listing on subdomain or DNSLink gw #7205

lidel opened this issue Apr 23, 2020 · 2 comments · Fixed by #7219
Labels
need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization topic/gateway Topic gateway

Comments

@lidel
Copy link
Member

lidel commented Apr 23, 2020

Version information:

0.5.0-rc3

Description:

Directory listing in Subdomain mode is missing the CID info at the top:

path-2020-04-23--14-02-07

subdomain-2020-04-23--14-01-33

I am not sure if it is a feature (could be something we did for DNSLink websites in past), but feels like a bug in subdomain context.

I'd like to change this so we ALWAYS show the full content path in Index of ..
(including subdomains and DNSLink websites)

Thoughts? @jessicaschilling @Stebalien

@lidel lidel added topic/gateway Topic gateway need/triage Needs initial labeling and prioritization need/analysis Needs further analysis before proceeding labels Apr 23, 2020
@jessicaschilling
Copy link
Contributor

jessicaschilling commented Apr 23, 2020

Sounds good to me. If it's not too off-topic, this would also be a good chance to fix ipfs/dir-index-html#2 -- in which the content of "Index of ..." would separately linked for each directory (so you can use it to traverse directory structure by clicking on an individual part between slashes). I'm afraid it's not something I can fix, though. :(

@Stebalien
Copy link
Member

I agree. We should always show the full path, even for DNSLink websites.

Stebalien added a commit that referenced this issue Apr 26, 2020
Even for dnslink websites.

fixes #7205
Stebalien added a commit that referenced this issue Apr 27, 2020
Even for dnslink websites.

fixes #7205
Stebalien added a commit that referenced this issue Apr 27, 2020
Even for dnslink websites.

fixes #7205
Stebalien added a commit that referenced this issue Apr 27, 2020
Even for dnslink websites.

fixes #7205
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
Even for dnslink websites.

fixes ipfs#7205
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
Even for dnslink websites.

fixes ipfs#7205
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
Even for dnslink websites.

fixes ipfs#7205
hacdias pushed a commit to ipfs/boxo that referenced this issue Jan 27, 2023
Even for dnslink websites.

fixes ipfs/kubo#7205


This commit was moved from ipfs/kubo@46ae021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/analysis Needs further analysis before proceeding need/triage Needs initial labeling and prioritization topic/gateway Topic gateway
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants