Skip to content

Commit

Permalink
docs(Makefile) vendoring help
Browse files Browse the repository at this point in the history 
to help out with concerns like this one: #377 (comment)
  • Loading branch information
Brian Tiger Chow committed Nov 24, 2014
1 parent 95666d1 commit be52116
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ godep:
# saves/vendors third-party dependencies to Godeps/_workspace
# -r flag rewrites import paths to use the vendored path
# ./... performs operation on all packages in tree
#
# NB: If you're missing packages in your GOPATH, before running
# `make vendor`, run `godep restore`. This will copy all of the
# vendored packages into your GOPATH and silence the errors.
vendor: godep
godep save -r ./...

Expand Down

2 comments on commit be52116

@btc
Copy link
Contributor

@btc btc commented on be52116 Nov 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should put godep restore into our makefile, or at least make the error more understandable to users. (The bad part of putting it in is it may blow out versions people had set there purposefully, which is sketchy).

Thoughts @maybebtc ?

@jbenet I added this note to the Makefile. Since godep restore is a really destructive operation, I thought to play it safe. My current belief is that this will be sufficient in practice. Perhaps if it happens again, we escalate?

@whyrusleeping
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do something like:

export GOPATH=`pwd`/gopkg
mkdir -p $GOPATH
godep restore ./...
...

Please sign in to comment.