This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
docs: document type field in ipfs.get output #3424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a test for deeply nested directories
hugomrdias
suggested changes
Nov 26, 2020
docs/core-api/FILES.md
Outdated
| content.push(chunk) | ||
| } | ||
|
|
||
| console.log(content) | ||
| } | ||
| ``` | ||
|
|
||
| When invoking this method via the HTTP API client, the response arrives as a stream in the tar format containing the entire contents of the file or directory tree. |
There was a problem hiding this comment.
the user doesnt care about stream being a tar, maybe its best to not mention tar here to avoid confusion
There was a problem hiding this comment.
Good shout, I've updated the text
achingbrain
commented
Nov 26, 2020
Co-authored-by: Hugo Dias <[email protected]>
hugomrdias
suggested changes
Nov 26, 2020
Co-authored-by: Hugo Dias <[email protected]>
hugomrdias
approved these changes
Nov 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a test for deeply nested directories