This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: changing another ipfs.add to importer #3057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
suggested changes
Jun 5, 2020
Co-authored-by: Alex Potsides <[email protected]>
|
I don't think this will be needed by rust-ipfs anymore. Also I am not sure if this would be very important in the API leveling sense: before add there can of course be trees created manually however add is the first big feature with the creation directory and other unixfs trees so that there is something to be pinned (recursively). |
|
Sounds good. I will close |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This [WIP] PR modifies the
pin/*.jstests to useimporterinstead ofipfs.add. This will be developed in tandem with rs-ipfs/rust-ipfs#152