This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry didn’t notice this was still in draft! |
Yeah - just wanted to get this all somewhere that a) wasn't on my laptop and b) where we can talk about the API while the implementation settles (e.g. I write tests) |
alanshaw
reviewed
Dec 2, 2019
This was referenced Dec 9, 2019
Closed
alanshaw
added
exp/expert
Having worked on the specific codebase is important
P0
Critical: Tackled by core team ASAP
labels
Dec 16, 2019
Adds metadata support. Specifying metadata: ```console $ jsipfs add --mode=0777 --mtime=100000 ./foo.txt ``` Respecting exsting metadata: ```console $ jsipfs add --preserve-mode --preserve-mtime ./foo.txt ``` Displaying metadata: ```console $ jsipfs ls Qmfoo -rw-r--r-- Nov 21, 2019, 09:46:23 AM CST bar.txt Qbar 0 ```
achingbrain
force-pushed
the
support-unixfs-metadata
branch
from
December 23, 2019 16:55
7728a3c
to
122c38e
Compare
The pubsub tests will be the death of me. |
alanshaw
approved these changes
Jan 9, 2020
@@ -36,6 +36,7 @@ const parser = yargs | |||
.commandDir('commands') | |||
.middleware(argv => Object.assign(argv, { | |||
getIpfs: utils.singleton(cb => utils.getIPFS(argv, cb)), | |||
getStdin: () => process.stdin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
exp/expert
Having worked on the specific codebase is important
P0
Critical: Tackled by core team ASAP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UnixFSv1.5 metadata support.
Specifying metadata:
$ jsipfs add --mode=0777 --mtime=100000 ./foo.txt
Respecting exsting metadata:
$ jsipfs add --preserve-mode --preserve-mtime ./foo.txt
Displaying metadata:
MFS gets
chmod
andtouch
commands:RPC Changes:
/api/v0/files/chmod
and/api/v0/files/touch
operations addedmtime
andmode
arguments added to/api/v0/files/write
and/api/v0/add
Depends on: