Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

Update deps #1338

Merged
merged 4 commits into from
May 6, 2018
Merged

Update deps #1338

merged 4 commits into from
May 6, 2018

Conversation

daviddias
Copy link
Member

No description provided.

@daviddias
Copy link
Member Author

A normal jsipfs init is now failing making all CLI tests fail. Investigating

» jsipfs init
initializing ipfs node at /Users/imp/.jsipfs
generating 2048-bit RSA keypair...events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: repo is not initialized yet
    at parallel (/Users/imp/code/js-ipfs/node_modules/ipfs-repo/src/index.js:216:41)
    at /Users/imp/code/js-ipfs/node_modules/async/internal/parallel.js:39:9
    at /Users/imp/code/js-ipfs/node_modules/async/internal/once.js:12:16
    at iterateeCallback (/Users/imp/code/js-ipfs/node_modules/async/internal/eachOfLimit.js:44:17)
    at /Users/imp/code/js-ipfs/node_modules/async/internal/onlyOnce.js:12:16
    at /Users/imp/code/js-ipfs/node_modules/async/internal/parallel.js:36:13
    at get (/Users/imp/code/js-ipfs/node_modules/ipfs-repo/src/version.js:53:18)
    at ReadFileContext.store.get (/Users/imp/code/js-ipfs/node_modules/ipfs-repo/src/version.js:29:18)
    at ReadFileContext.callback (/Users/imp/code/js-ipfs/node_modules/graceful-fs/graceful-fs.js:78:16)
    at FSReqWrap.readFileAfterOpen [as oncomplete] (fs.js:420:13)

@daviddias
Copy link
Member Author

The issue I was having was introduced with ipfs/js-ipfs-repo@755b5c6, reverted ipfs-repo to 0.20.0.

@hugomrdias can you triple check what caused the issue? Seems that the merge of two error states on ipfs-repo, if err and res.config is not being handled correctly.

@daviddias daviddias changed the base branch from master to faster-tests May 6, 2018 16:14
@daviddias daviddias changed the base branch from faster-tests to master May 6, 2018 16:14
@daviddias daviddias requested a review from victorb May 6, 2018 16:21
@daviddias daviddias changed the title Ci green Update deps May 6, 2018
@daviddias
Copy link
Member Author

Only one flaky test made the CI fail :(

 1) interface-ipfs-core tests,.files

       "after all" hook:

     AssertionError: The libp2p node is not started yet

    at Node.dialProtocol (webpack:///node_modules/libp2p/src/index.js:248:0 <- node_modules/aegir/src/config/karma-webpack-bundle.js:277981:5)

    at libp2p.dialProtocol (webpack:///node_modules/ipfs-bitswap/src/network.js:169:0 <- node_modules/aegir/src/config/karma-webpack-bundle.js:256030:21)

Going to go ahead and merge this one so that other PRs can rebased on master. Soon there will be no more flaky tests!

@daviddias daviddias merged commit 1048c25 into master May 6, 2018
@daviddias daviddias deleted the ci-green branch May 6, 2018 16:30
@ghost ghost removed the status/in-progress In progress label May 6, 2018
@victorb
Copy link
Member

victorb commented May 6, 2018

Only one flaky test made the CI fail :(

@diasdavid in the future when we see flaky tests, let's add this.retries(3) to them + a comment, so we can make them less flaky.

@daviddias
Copy link
Member Author

@victorbjelkholm 👍. Waiting to have #1336 merged :)

@jacobheun
Copy link
Contributor

@diasdavid @hugomrdias I'm not sure if anyone else is looking into the initialization failure at the moment, but I am working on that and a few other things as part of the node 10 build failure fix. I believe I have that failure resolved, just taking care of a few other items to get the tests green.

fyi: @alanshaw

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants