"jsipfs swarm peers" listening all known address instead of used address to connect to that peer

[victorb]

• Version: 0.25.0
• Platform: macOS
• Subsystem: libp2p

Type: Bug

Severity: High

Description:

swarm peers command (on CLI at least) seems to not be returning the right peers. First problem is that every peer that is connected is being added with each listener, for example, node QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop would show up as:

/ip4/127.0.0.1/tcp/4002/ipfs/QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop
/ip4/10.185.197.146/tcp/4002/ipfs/QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop
/ip4/127.0.0.1/tcp/4003/ws/ipfs/QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop
/ip4/127.0.0.1/tcp/4002/ipfs/QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop
/ip4/10.185.197.146/tcp/4002/ipfs/QmVeWHZtuF2fMWDNF8ef2XoToLdyzuH9nwBexKqi4FmXop

Instead of just being listed once as expected. Which means swarm peers | wc -l will return addresses the node is connected to, instead of peers.

Steps to reproduce the error:

• Initialize two nodes
• Start one of the nodes
• Print out jsipfs swarm peers and jsipfs swarm peers | wc -l, note down the number
• Start the other node and wait five seconds for them to connect automatically
• Print out jsipfs swarm peers and jsipfs swarm peers | wc -l, compare with previous number

[daviddias]

Seems that issue is here:

js-ipfs/src/core/components/swarm.js

Lines 12 to 45 in a85cf70

	peers: promisify((opts, callback) => {
	if (typeof opts === 'function') {
	callback = opts
	opts = {}
	}
	if (!self.isOnline()) {
	return callback(OFFLINE_ERROR)
	}
	const verbose = opts.v || opts.verbose
	// TODO: return latency and streams when verbose is set
	// we currently don't have this information
	const peers = values(self._peerInfoBook.getAll())
	.filter((peer) => peer.isConnected())
	const peerList = flatMap(peers, (peer) => {
	return peer.multiaddrs.toArray().map((addr) => {
	const res = {
	addr: addr,
	peer: peer
	}
	if (verbose) {
	res.latency = 'unknown'
	}
	return res
	})
	})
	callback(null, peerList)
	}),

The filtering is being done by asserting if we are connected, when instead we should be picking the used address from that same call -- see https://github.com/libp2p/js-peer-info/blob/6fe1352ec9105b3e79c269d7c4b668ec0322d995/src/index.js#L32-L34 --.

Looks like a small patch, wanna push a PR?

[victorb]

@diasdavid I'll be happy to :)

[victorb]

Since #960 was merged, this has been fixed

[daviddias]

wwoot! Thank you @victorbjelkholm for handling this one :)