Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing devDependencies to package.json #2052

Closed
wants to merge 1 commit into from

Conversation

Funarp
Copy link

@Funarp Funarp commented Oct 13, 2022

Dep eslint-plugin-n is required for yarn start or build, missing this will lead errors. and also eslint-plugin-node should be removed if all test passed, cause eslint-plugin-n is updated eslint-plugin-node

Dep eslint-plugin-n is required for yarn start or build, missing this will lead errors. and also eslint-plugin-node should be removed if all test passed, cause eslint-plugin-n is updated eslint-plugin-node
@Funarp Funarp requested a review from a team as a code owner October 13, 2022 17:20
@welcome
Copy link

welcome bot commented Oct 13, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@Funarp Funarp changed the title Add missing devDependencies to package.json fix: add missing devDependencies to package.json Oct 13, 2022
@SgtPooki
Copy link
Member

SgtPooki commented Jan 11, 2023

i'm not getting the same errors when using npm build after npm i on main.

Can you provide more information about what errors you receive? Are you only receiving them with yarn ? we don't provide support for yarn for this project, but I'm happy to help you debug any issues

I do agree that we should replace the plugin with the currently maintained one, though I'd like to address the issue you ran into if possible.

related:

@SgtPooki SgtPooki added the need/author-input Needs input from the original author label Jan 11, 2023
@SgtPooki SgtPooki marked this pull request as draft January 11, 2023 00:22
@SgtPooki
Copy link
Member

SgtPooki commented Feb 8, 2023

this is being handled by #2092

@SgtPooki SgtPooki closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants