Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pinning settings modal #1539

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Feat/pinning settings modal #1539

merged 2 commits into from
Jul 9, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Result: image

TODOS:

  • Add link/action to add custom integration
  • Handle clicks on modal items and proceed with the "add service" journey

@rafaelramalho19 rafaelramalho19 changed the base branch from master to feat/pinning-settings July 2, 2020 18:40
jessicaschilling
jessicaschilling approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed the code, but based on the screenshots, LGTM. Will defer to @lidel on code review!

lidel
lidel requested changes Jul 3, 2020
View reviewed changes
src/bundles/pinning.js Outdated Show resolved Hide resolved
@rafaelramalho19 rafaelramalho19 mentioned this pull request Jul 3, 2020
Merged
@rafaelramalho19 rafaelramalho19 requested a review from lidel July 9, 2020 14:58
@rafaelramalho19 rafaelramalho19 force-pushed the feat/pinning-settings-modal branch from e4826d0 to cde5d69 Compare July 9, 2020 15:27
@rafaelramalho19 rafaelramalho19 merged commit a39c3ef into feat/pinning-settings Jul 9, 2020
@rafaelramalho19 rafaelramalho19 deleted the feat/pinning-settings-modal branch July 9, 2020 15:36
@internetbuilder internetbuilder mentioned this pull request Oct 23, 2022
Open
@xaiksan1 xaiksan1 mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaschilling jessicaschilling jessicaschilling approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelramalho19 @lidel @jessicaschilling