Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in IPFS desktop page #1292

Merged
merged 2 commits into from
Sep 28, 2022
Merged

Fix links in IPFS desktop page #1292

merged 2 commits into from
Sep 28, 2022

Conversation

ElPaisano
Copy link
Contributor

While going through https://docs.ipfs.tech/install/ipfs-desktop/, I noticed two busted links:

  1. The link in the last sentence of the Windows install The IPFS Desktop application has finished installing. You can now start to add your site. returns a 404
  2. The link in the last sentence of the Mac install The IPFS Desktop application has finished installing. You can now start to add your site. doesn't go anywhere.

I'm guessing they were supposed to go to https://docs.ipfs.tech/how-to/websites-on-ipfs/single-page-website/ so I updated them accordingly. LMK if this is not the case.

@TMoMoreau
Copy link
Contributor

Weird, the page still exists, not sure why it's returning a 404.
https://docs.ipfs.tech/how-to/websites-on-ipfs/single-page-website/#add-your-site

We should try and keep the same link, the first half of the /single-page-website/ page is just installation instructions anyway, which is where people who click the link are coming from.

Really not sure why it's 404-ing though. Maybe try and just paste the link above into the doc first, we know that one works.

@ElPaisano
Copy link
Contributor Author

ElPaisano commented Sep 27, 2022

@TMoMoreau thanks for looking. I made updates in 6b0a31c

I changed the links back to https://docs.ipfs.tech/how-to/websites-on-ipfs/single-page-website/#add-your-site per your comment above.

I think the 404 was being caused because a . was missing in the path, so the link was rendering as https://docs.ipfs.tech/install/how-to/websites-on-ipfs/single-page-website/#add-your-site when it should render as https://docs.ipfs.tech/how-to/websites-on-ipfs/single-page-website/#add-your-site. I added the missing ..

As for the other one, I think it just needed the full path, so I added that.

Both updated links seem to work. LMK if you see anything

Copy link
Contributor

@TMoMoreau TMoMoreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets merge and test the links once the changes go live.

@TMoMoreau TMoMoreau merged commit 1a1ec0d into ipfs:main Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants