Better error handling and fix file uploading. #198
Conversation
| @@ -1,10 +1,7 @@ | |||
| import API from 'ipfs-api' | |||
| import notifier from 'node-notifier' | |||
| import {join} from 'path' | |||
| import {getIPFS, logger} from './../init' | |||
There was a problem hiding this comment.
this works in Node.js due to transpilation, correct? Do we want to use two module systems in the same file? I'ld rather prefer to keep using CJS on Node.js side and ES6 for browser/ui side.
There was a problem hiding this comment.
The whole code base already uses es6 modules as everything gets transpiled anyway. If they are different repos we can have that differentiation, but in this case I'd rather have consistency in the repo.
(Also this is not changed in this PR)
There was a problem hiding this comment.
noted, why have const clipboard = require('clipboard') (line 8) then? 👍 for consistency
There was a problem hiding this comment.
hmmm no idea why that's there oO
dignifiedquire
force-pushed
the
improveme
branch
from
32c0841 to
7fef422
Compare
Also adds better error handling and wraps multiple file uploads into a directory now. Closes #153
dignifiedquire
force-pushed
the
improveme
branch
from
7fef422 to
cd5a5e3
Compare
Better error handling and fix file uploading.
|
LGTM. There is no tests still, makes contributions really hard to do. |
well you could write some :P |
Closes #153