fix: allow multiple gateway and api ports #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
Co-Authored-By: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
License: MIT Signed-off-by: Henrique Dias <[email protected]>
Just added one to make sure it boots up with multiple addresses. It does not test the case when there are collisions. Will do that in the feature. There are a lot of tests planned! |
License: MIT Signed-off-by: Henrique Dias <[email protected]>
|
As per @alanshaw's suggestion, the dialog was changed:
|
lidel
requested changes
Sep 6, 2019
lidel
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1091
On the case there is an array of API or Gateway addresses and one or more of them collide with already busy ports, we show this message:
Users that have multiple addresses for API/Gateway already changed the configuration on their own and know how to solve this kind of issues.
License: MIT
Signed-off-by: Henrique Dias [email protected]