Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display channel-appropriate release notes upon Companion version update #913

Merged
merged 9 commits into from
Jul 21, 2020
Merged

Display channel-appropriate release notes upon Companion version update #913

merged 9 commits into from
Jul 21, 2020

Conversation

jessicaschilling
Copy link
Contributor

This PR adds functionality for displaying the GitHub page for latest version release notes (taken from browser.runtime.getManifest().version in order to be accurate for Beta channel users) upon version update of the extension.

Closes #912

@jessicaschilling jessicaschilling mentioned this pull request Jul 16, 2020
Closed
@jessicaschilling jessicaschilling requested a review from lidel July 16, 2020 20:25
@jessicaschilling
Copy link
Contributor Author

@lidel, for review at your leisure -- please note this works as intended if I swap showLandingPage: 'onInstallWelcome' and showLandingPage: 'onVersionUpdate' in the code and reload the extension, but is there a better way of testing this?

(Thanks @rafaelramalho19 for the help!)

@lidel
feat: displayReleaseNotes toggle
a81a8d8 
This makes it possible to turn off release notes on each update.
lidel
lidel approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you @jessicaschilling !

I was a bit worried there will be a set of users very vocal that they can't turn this type of behavior off. I've added toggle to Preferences – similar to the one we already had for disabling all OS-level notifications.

Let me know if it is ok.

add-on/_locales/en/messages.json Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor Author

@lidel Great idea to put it in a preference, thank you! I tweaked the text ever so slightly. Merging. 😊

@jessicaschilling jessicaschilling merged commit e4afb31 into master Jul 21, 2020
@jessicaschilling jessicaschilling deleted the feat/release-notes-on-update branch July 21, 2020 18:35
@lidel
Copy link
Member

lidel commented Jul 21, 2020

Just released v2.14.0.959 and it worked 🚀 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display release notes upon updating Companion version
2 participants
@jessicaschilling @lidel