test for reader / sizing behavior on large files #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
reviewed
Aug 16, 2022
rvagg
reviewed
Aug 16, 2022
rvagg
reviewed
Aug 16, 2022
rvagg
reviewed
Aug 16, 2022
rvagg
reviewed
Aug 16, 2022
There was a problem hiding this comment.
good tests, but 32-bit are breaking OOM and I'm a little concerned about the terseness of some of this when we're getting so deep in the weeds - it would be nice to have less terse variable names and more notes inline to support future maintainers grokking this
rvagg
approved these changes
Aug 22, 2022
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 12, 2023
test for reader / sizing behavior on large files This commit was moved from ipfs/go-unixfsnode@1fca571
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #33