Add unixfs to UnixFS path selector tail #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
At the end of pathing into a UnixFS directory, you encounter a UnixFS object (whether file, directory, symlink, etc). You almost always want to reify that node, rather than work with the base protobuf type. This has no effect on single block unixfs files, but for multiblock files and directories, this is the only way you can work with the resulting object properly for the visitor function.
Implementation
fix the selector for paths, wrapping the last matcher node in an ExploreInterpretAs, since the tail
end of a path into a unixfs dir is itself a unixfsnode