-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cannot call SetPrimaryCore after using a Tee logger #121
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
0ae9972
to
9fc42bc
Compare
@MDobak : can you please take a look here as this looks related to your recent changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunate... but I can't think of a better fix. In the "good" case where pointers are being used, this will be equivalent to ==
.
Could you fix the comparison in DeleteCore as well?
Signed-off-by: Manfred Touron <[email protected]>
9fc42bc
to
410466b
Compare
@Stebalien, done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ipfs/go-log](https://github.com/ipfs/go-log) | `v1.0.5` -> `v2.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ipfs/go-log (github.com/ipfs/go-log)</summary> ### [`v2.5.1`](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) ### [`v2.5.0`](https://github.com/ipfs/go-log/releases/tag/v2.5.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.4.0...v2.5.0) #### What's Changed - update go.uber.org/zap to v1.19.1 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/130](https://github.com/ipfs/go-log/pull/130) - Config inspection by [@​elijaharita](https://github.com/elijaharita) in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) #### New Contributors - [@​elijaharita](https://github.com/elijaharita) made their first contribution in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) **Full Changelog**: ipfs/go-log@v2.4.0...v2.5.0 ### [`v2.4.0`](https://github.com/ipfs/go-log/releases/tag/v2.4.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.3.0...v2.4.0) #### What's Changed - In addition to StdOut/Err check the outfile for TTYness by [@​ribasushi](https://github.com/ribasushi) in [https://github.com/ipfs/go-log/pull/117](https://github.com/ipfs/go-log/pull/117) - Add WithStacktrace untility by [@​Kubuxu](https://github.com/Kubuxu) in [https://github.com/ipfs/go-log/pull/118](https://github.com/ipfs/go-log/pull/118) - sync: update CI config files by [@​web3-bot](https://github.com/web3-bot) in [https://github.com/ipfs/go-log/pull/119](https://github.com/ipfs/go-log/pull/119) - Document environment variables by [@​Stebalien](https://github.com/Stebalien) in [https://github.com/ipfs/go-log/pull/120](https://github.com/ipfs/go-log/pull/120) - fix: cannot call SetPrimaryCore after using a Tee logger by [@​moul](https://github.com/moul) in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) - update mattn/go-isatty to v0.0.14 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/123](https://github.com/ipfs/go-log/pull/123) #### New Contributors - [@​moul](https://github.com/moul) made their first contribution in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) **Full Changelog**: ipfs/go-log@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/ipfs/go-log/releases/tag/v2.3.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.2.0...v2.3.0) Features: - Do not output ANSI-color sequences unless one of the outputs is a TTY. - New format type `GOLOG_LOG_FMT=color` for cases when capturing color in a file is desirable ### [`v2.2.0`](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) ### [`v2.1.3`](https://github.com/ipfs/go-log/releases/tag/v2.1.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.2...v2.1.3) Update deps. ### [`v2.1.2`](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) ### [`v2.1.1`](https://github.com/ipfs/go-log/releases/tag/v2.1.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.0...v2.1.1) This patch release fixes an issue where setting the log level of a subsystem to anything below error at runtime wouldn't have any effect. ### [`v2.1.0`](https://github.com/ipfs/go-log/releases/tag/v2.1.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.8...v2.1.0) This release: 1. Adds support for *subscribing* to log events by calling `NewPipeReader`. 2. Won't log to stderr if GOLOG_FILE has been specified. 3. Allows re-configuring the logging subsystem at runtime by calling `SetupLogging`. ### [`v2.0.8`](https://github.com/ipfs/go-log/releases/tag/v2.0.8) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.7...v2.0.8) Fixes the Warningf implementation introduced in v2.0.7 to actually skip a level and not log error messages all over the place. ### [`v2.0.7`](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) ### [`v2.0.6`](https://github.com/ipfs/go-log/releases/tag/v2.0.6) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.5...v2.0.6) Add back pre-deprecated Warning and Warningf functions so this logger can be used by libraries like badger that expect such functions. ### [`v2.0.5`](https://github.com/ipfs/go-log/releases/tag/v2.0.5) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.4...v2.0.5) Update zap and remove unnecessary deps. ### [`v2.0.4`](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) ### [`v2.0.3`](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) ### [`v2.0.2`](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) ### [`v2.0.1`](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) ### [`v2.0.0`](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) [Compare Source](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuMzAxLjQiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ipfs/go-log](https://github.com/ipfs/go-log) | `v1.0.5` -> `v2.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ipfs/go-log (github.com/ipfs/go-log)</summary> ### [`v2.5.1`](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) ### [`v2.5.0`](https://github.com/ipfs/go-log/releases/tag/v2.5.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.4.0...v2.5.0) #### What's Changed - update go.uber.org/zap to v1.19.1 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/130](https://github.com/ipfs/go-log/pull/130) - Config inspection by [@​elijaharita](https://github.com/elijaharita) in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) #### New Contributors - [@​elijaharita](https://github.com/elijaharita) made their first contribution in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) **Full Changelog**: ipfs/go-log@v2.4.0...v2.5.0 ### [`v2.4.0`](https://github.com/ipfs/go-log/releases/tag/v2.4.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.3.0...v2.4.0) #### What's Changed - In addition to StdOut/Err check the outfile for TTYness by [@​ribasushi](https://github.com/ribasushi) in [https://github.com/ipfs/go-log/pull/117](https://github.com/ipfs/go-log/pull/117) - Add WithStacktrace untility by [@​Kubuxu](https://github.com/Kubuxu) in [https://github.com/ipfs/go-log/pull/118](https://github.com/ipfs/go-log/pull/118) - sync: update CI config files by [@​web3-bot](https://github.com/web3-bot) in [https://github.com/ipfs/go-log/pull/119](https://github.com/ipfs/go-log/pull/119) - Document environment variables by [@​Stebalien](https://github.com/Stebalien) in [https://github.com/ipfs/go-log/pull/120](https://github.com/ipfs/go-log/pull/120) - fix: cannot call SetPrimaryCore after using a Tee logger by [@​moul](https://github.com/moul) in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) - update mattn/go-isatty to v0.0.14 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/123](https://github.com/ipfs/go-log/pull/123) #### New Contributors - [@​moul](https://github.com/moul) made their first contribution in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) **Full Changelog**: ipfs/go-log@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/ipfs/go-log/releases/tag/v2.3.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.2.0...v2.3.0) Features: - Do not output ANSI-color sequences unless one of the outputs is a TTY. - New format type `GOLOG_LOG_FMT=color` for cases when capturing color in a file is desirable ### [`v2.2.0`](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) ### [`v2.1.3`](https://github.com/ipfs/go-log/releases/tag/v2.1.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.2...v2.1.3) Update deps. ### [`v2.1.2`](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) ### [`v2.1.1`](https://github.com/ipfs/go-log/releases/tag/v2.1.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.0...v2.1.1) This patch release fixes an issue where setting the log level of a subsystem to anything below error at runtime wouldn't have any effect. ### [`v2.1.0`](https://github.com/ipfs/go-log/releases/tag/v2.1.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.8...v2.1.0) This release: 1. Adds support for *subscribing* to log events by calling `NewPipeReader`. 2. Won't log to stderr if GOLOG_FILE has been specified. 3. Allows re-configuring the logging subsystem at runtime by calling `SetupLogging`. ### [`v2.0.8`](https://github.com/ipfs/go-log/releases/tag/v2.0.8) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.7...v2.0.8) Fixes the Warningf implementation introduced in v2.0.7 to actually skip a level and not log error messages all over the place. ### [`v2.0.7`](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) ### [`v2.0.6`](https://github.com/ipfs/go-log/releases/tag/v2.0.6) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.5...v2.0.6) Add back pre-deprecated Warning and Warningf functions so this logger can be used by libraries like badger that expect such functions. ### [`v2.0.5`](https://github.com/ipfs/go-log/releases/tag/v2.0.5) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.4...v2.0.5) Update zap and remove unnecessary deps. ### [`v2.0.4`](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) ### [`v2.0.3`](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) ### [`v2.0.2`](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) ### [`v2.0.1`](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) ### [`v2.0.0`](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) [Compare Source](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMDEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjMwMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ipfs/go-log](https://github.com/ipfs/go-log) | `v1.0.5` -> `v2.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ipfs/go-log (github.com/ipfs/go-log)</summary> ### [`v2.5.1`](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) ### [`v2.5.0`](https://github.com/ipfs/go-log/releases/tag/v2.5.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.4.0...v2.5.0) #### What's Changed - update go.uber.org/zap to v1.19.1 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/130](https://github.com/ipfs/go-log/pull/130) - Config inspection by [@​elijaharita](https://github.com/elijaharita) in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) #### New Contributors - [@​elijaharita](https://github.com/elijaharita) made their first contribution in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) **Full Changelog**: ipfs/go-log@v2.4.0...v2.5.0 ### [`v2.4.0`](https://github.com/ipfs/go-log/releases/tag/v2.4.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.3.0...v2.4.0) #### What's Changed - In addition to StdOut/Err check the outfile for TTYness by [@​ribasushi](https://github.com/ribasushi) in [https://github.com/ipfs/go-log/pull/117](https://github.com/ipfs/go-log/pull/117) - Add WithStacktrace untility by [@​Kubuxu](https://github.com/Kubuxu) in [https://github.com/ipfs/go-log/pull/118](https://github.com/ipfs/go-log/pull/118) - sync: update CI config files by [@​web3-bot](https://github.com/web3-bot) in [https://github.com/ipfs/go-log/pull/119](https://github.com/ipfs/go-log/pull/119) - Document environment variables by [@​Stebalien](https://github.com/Stebalien) in [https://github.com/ipfs/go-log/pull/120](https://github.com/ipfs/go-log/pull/120) - fix: cannot call SetPrimaryCore after using a Tee logger by [@​moul](https://github.com/moul) in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) - update mattn/go-isatty to v0.0.14 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/123](https://github.com/ipfs/go-log/pull/123) #### New Contributors - [@​moul](https://github.com/moul) made their first contribution in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) **Full Changelog**: ipfs/go-log@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/ipfs/go-log/releases/tag/v2.3.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.2.0...v2.3.0) Features: - Do not output ANSI-color sequences unless one of the outputs is a TTY. - New format type `GOLOG_LOG_FMT=color` for cases when capturing color in a file is desirable ### [`v2.2.0`](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) ### [`v2.1.3`](https://github.com/ipfs/go-log/releases/tag/v2.1.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.2...v2.1.3) Update deps. ### [`v2.1.2`](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) ### [`v2.1.1`](https://github.com/ipfs/go-log/releases/tag/v2.1.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.0...v2.1.1) This patch release fixes an issue where setting the log level of a subsystem to anything below error at runtime wouldn't have any effect. ### [`v2.1.0`](https://github.com/ipfs/go-log/releases/tag/v2.1.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.8...v2.1.0) This release: 1. Adds support for *subscribing* to log events by calling `NewPipeReader`. 2. Won't log to stderr if GOLOG_FILE has been specified. 3. Allows re-configuring the logging subsystem at runtime by calling `SetupLogging`. ### [`v2.0.8`](https://github.com/ipfs/go-log/releases/tag/v2.0.8) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.7...v2.0.8) Fixes the Warningf implementation introduced in v2.0.7 to actually skip a level and not log error messages all over the place. ### [`v2.0.7`](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) ### [`v2.0.6`](https://github.com/ipfs/go-log/releases/tag/v2.0.6) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.5...v2.0.6) Add back pre-deprecated Warning and Warningf functions so this logger can be used by libraries like badger that expect such functions. ### [`v2.0.5`](https://github.com/ipfs/go-log/releases/tag/v2.0.5) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.4...v2.0.5) Update zap and remove unnecessary deps. ### [`v2.0.4`](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) ### [`v2.0.3`](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) ### [`v2.0.2`](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) ### [`v2.0.1`](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) ### [`v2.0.0`](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) [Compare Source](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/ipfs/go-log](https://github.com/ipfs/go-log) | `v1.0.5` -> `v2.5.1` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fipfs%2fgo-log/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fipfs%2fgo-log/v1.0.5/v2.5.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>ipfs/go-log (github.com/ipfs/go-log)</summary> ### [`v2.5.1`](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.5.0...v2.5.1) ### [`v2.5.0`](https://github.com/ipfs/go-log/releases/tag/v2.5.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.4.0...v2.5.0) #### What's Changed - update go.uber.org/zap to v1.19.1 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/130](https://github.com/ipfs/go-log/pull/130) - Config inspection by [@​elijaharita](https://github.com/elijaharita) in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) #### New Contributors - [@​elijaharita](https://github.com/elijaharita) made their first contribution in [https://github.com/ipfs/go-log/pull/129](https://github.com/ipfs/go-log/pull/129) **Full Changelog**: ipfs/go-log@v2.4.0...v2.5.0 ### [`v2.4.0`](https://github.com/ipfs/go-log/releases/tag/v2.4.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.3.0...v2.4.0) #### What's Changed - In addition to StdOut/Err check the outfile for TTYness by [@​ribasushi](https://github.com/ribasushi) in [https://github.com/ipfs/go-log/pull/117](https://github.com/ipfs/go-log/pull/117) - Add WithStacktrace untility by [@​Kubuxu](https://github.com/Kubuxu) in [https://github.com/ipfs/go-log/pull/118](https://github.com/ipfs/go-log/pull/118) - sync: update CI config files by [@​web3-bot](https://github.com/web3-bot) in [https://github.com/ipfs/go-log/pull/119](https://github.com/ipfs/go-log/pull/119) - Document environment variables by [@​Stebalien](https://github.com/Stebalien) in [https://github.com/ipfs/go-log/pull/120](https://github.com/ipfs/go-log/pull/120) - fix: cannot call SetPrimaryCore after using a Tee logger by [@​moul](https://github.com/moul) in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) - update mattn/go-isatty to v0.0.14 by [@​marten-seemann](https://github.com/marten-seemann) in [https://github.com/ipfs/go-log/pull/123](https://github.com/ipfs/go-log/pull/123) #### New Contributors - [@​moul](https://github.com/moul) made their first contribution in [https://github.com/ipfs/go-log/pull/121](https://github.com/ipfs/go-log/pull/121) **Full Changelog**: ipfs/go-log@v2.3.0...v2.4.0 ### [`v2.3.0`](https://github.com/ipfs/go-log/releases/tag/v2.3.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.2.0...v2.3.0) Features: - Do not output ANSI-color sequences unless one of the outputs is a TTY. - New format type `GOLOG_LOG_FMT=color` for cases when capturing color in a file is desirable ### [`v2.2.0`](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.3...v2.2.0) ### [`v2.1.3`](https://github.com/ipfs/go-log/releases/tag/v2.1.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.2...v2.1.3) Update deps. ### [`v2.1.2`](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.1...v2.1.2) ### [`v2.1.1`](https://github.com/ipfs/go-log/releases/tag/v2.1.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.1.0...v2.1.1) This patch release fixes an issue where setting the log level of a subsystem to anything below error at runtime wouldn't have any effect. ### [`v2.1.0`](https://github.com/ipfs/go-log/releases/tag/v2.1.0) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.8...v2.1.0) This release: 1. Adds support for *subscribing* to log events by calling `NewPipeReader`. 2. Won't log to stderr if GOLOG_FILE has been specified. 3. Allows re-configuring the logging subsystem at runtime by calling `SetupLogging`. ### [`v2.0.8`](https://github.com/ipfs/go-log/releases/tag/v2.0.8) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.7...v2.0.8) Fixes the Warningf implementation introduced in v2.0.7 to actually skip a level and not log error messages all over the place. ### [`v2.0.7`](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.6...v2.0.7) ### [`v2.0.6`](https://github.com/ipfs/go-log/releases/tag/v2.0.6) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.5...v2.0.6) Add back pre-deprecated Warning and Warningf functions so this logger can be used by libraries like badger that expect such functions. ### [`v2.0.5`](https://github.com/ipfs/go-log/releases/tag/v2.0.5) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.4...v2.0.5) Update zap and remove unnecessary deps. ### [`v2.0.4`](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.3...v2.0.4) ### [`v2.0.3`](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.2...v2.0.3) ### [`v2.0.2`](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.1...v2.0.2) ### [`v2.0.1`](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) [Compare Source](https://github.com/ipfs/go-log/compare/v2.0.0...v2.0.1) ### [`v2.0.0`](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) [Compare Source](https://github.com/ipfs/go-log/compare/v1.0.5...v2.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 11pm every weekday,before 7am every weekday,every weekend" in timezone Europe/Brussels, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kairos-io/provider-kairos). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Previous behavior
Calling
SetPrimaryCore
after being configured with azapcore.Tee
causes apanic: runtime error: comparing uncomparable type zapcore.multiCore
New behavior
No panic
h/t @gfanton