Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable assertion on commit size -- it is correct after #31 #33

Merged
merged 1 commit into from
Jan 6, 2019
Merged

Re-enable assertion on commit size -- it is correct after #31 #33

merged 1 commit into from
Jan 6, 2019

Conversation

sameer
Copy link
Contributor

@sameer sameer commented Jan 5, 2019

No description provided.

@magik6k magik6k self-requested a review January 6, 2019 14:08
@magik6k
Copy link
Member

magik6k commented Jan 6, 2019 •
edited
Loading

Mind rebasing these 3 on master to see if they pass?

@sameer sameer force-pushed the commitsizecorrect branch from f8b3cac to 48dca49 Compare January 6, 2019 14:30
@sameer
Copy link
Contributor Author

sameer commented Jan 6, 2019 •
edited
Loading

Mind rebasing these 3 on master to see if they pass?

Done, they all pass but code coverage goes down in #35. Should I add tests for the Resolve(nil) calls?

magik6k
magik6k approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@magik6k magik6k merged commit ce1bac9 into ipfs:master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sameer @magik6k