Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gateway): show the absolute path and CID every time #7219

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

Stebalien
Copy link
Member

For gateway directory listings, always the absolute path and the CID of the current directory. Even for dnslink websites.

fixes #7205

Previously, we only showed this /ipns paths. However, knowing the hash of the
current directory is useful regardless.
@Stebalien
Copy link
Member Author

2020-04-26-161619_1279x834_scrot

@Stebalien Stebalien force-pushed the fix/listing-header branch 2 times, most recently from b65681d to 619c226 Compare April 27, 2020 00:16
Even for dnslink websites.

fixes #7205
@Stebalien Stebalien force-pushed the fix/listing-header branch from 619c226 to 46ae021 Compare April 27, 2020 00:19
@Stebalien Stebalien added this to the go-ipfs 0.6 milestone Apr 27, 2020
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, especially important for DNSLink ones, thank you!

@Stebalien Stebalien merged commit ffe35df into master Apr 29, 2020
@Stebalien Stebalien mentioned this pull request May 26, 2020
77 tasks
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
feat(gateway): show the absolute path and CID every time

This commit was moved from ipfs/kubo@ffe35df
@hacdias hacdias deleted the fix/listing-header branch May 9, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing content path when dir listing on subdomain or DNSLink gw
3 participants