This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
Feat/add ignore rules #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Feb 26, 2020
There was a problem hiding this comment.
Thanks for helping out @corntoole!
I've made a few suggestions for code changes inline.
Could we also add a test that verifies that using a .gitignore style file works?
|
Thanks for the review @dirkmc . I just pushed a commit to address most of the suggestions, and will respond to the remaining unresolved comments shortly. |
Stebalien
suggested changes
Mar 17, 2020
Stebalien
approved these changes
Mar 18, 2020
|
LGTM. Thanks! Could you rebase on master and squash? (we usually use merge commits to track PRs/features but I try to avoid reverse-merge commits). |
- add a filter that defines rules for ignoring hidden and/or files listed explicitly or defined in a gitignore file - update SerialFile construct to accept a Filter feat(add-file-ignore): fix tests, slight refactor - add new SerialFile constructor with original signature for backward compatibility - update tests for new SerialFile behavior feat(file-ignore): cleanup code+tests - address PR comments - add more documentation - use existing function for cross-platform hidden file detection - be more consistent when checking for hidden fies - add more examples+test cases feat(file-ignore): rework `Filter` constructor - add filter tests feat(file-ignore): apply exclude rules lazily - apply exclude rules from filter when iterating over dir contents instead of at serialFile construction time
corntoole
force-pushed
the
feat/add-ignore-rules
branch
from
8de2da5 to
90aef3a
Compare
|
Is this okay? I figured that you didn't mean Squash and merge since I don't have write access. |
|
Yep. Just squash and rebase. Thanks! |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 11, 2023
…ignore-rules Feat/add ignore rules This commit was moved from ipfs/go-ipfs-files@642f445
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Filterobject that can be used to define rules for which files should be ignored during ipfs file commands. It also updates theserialFiletype to use a filter to determine which files should be included. This is the first PR toward the re-implementation of the file ignore feature in go-ipfs: ipfs/kubo#3643