Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

modify Addresses.Gateway/API to array #6

Closed

Conversation

overbool
Copy link

@overbool overbool commented Sep 7, 2018

License: MIT
Signed-off-by: Overbool [email protected]

#7

License: MIT
Signed-off-by: Overbool <[email protected]>
@overbool overbool changed the title WIP: modify Addresses.Gateway/API to array modify Addresses.Gateway/API to array Sep 7, 2018
@ghost ghost self-requested a review September 15, 2018 19:13
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thank you 👍

Is there an fs-repo migration in the works already?

Stebalien added a commit that referenced this pull request Sep 15, 2018
Alternative to #6 that doesn't require a migration.
@Stebalien
Copy link
Member

Not yet. We could also try #11 but that may be too hacky.

Stebalien added a commit that referenced this pull request Sep 21, 2018
Alternative to #6 that doesn't require a migration.
Stebalien added a commit that referenced this pull request Sep 21, 2018
Alternative to #6 that doesn't require a migration.
@Stebalien
Copy link
Member

Closing in favor of #11 (avoids breaking our tooling).

@Stebalien Stebalien closed this Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants