This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
feat: add a transports section for enabling/disabling transports #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These let us zero-encode "default" to "null" (and omit it with "omitempty") so we don't have to hard code the default in the config.
This was never included in a release, and has been replaced by a flexible transport prioritization system.
Stebalien
force-pushed
the
feat/transports
branch
from
d1adea1 to
a303859
Compare
aschmahmann
reviewed
Jun 15, 2020
This makes it easier to resolve these fields.
Co-authored-by: Adin Schmahmann <[email protected]>
Co-authored-by: Adin Schmahmann <[email protected]>
aschmahmann
reviewed
Jun 16, 2020
Stebalien
commented
Jun 16, 2020
It's not a part of the JSON spec.
|
I think panicing seems like a reasonable approach as long as the valid/invalid cases are documented. It does mean putting in the error detection code for when to panic, but that's probably worthwhile. |
Stebalien
force-pushed
the
feat/transports
branch
from
dce3097 to
9949be6
Compare
aschmahmann
approved these changes
Jun 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.