-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: update CI config files #207
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Failing check fixed here: #212 |
cc346b1
to
6d19059
Compare
The tests on windows fail because CLI parser explicitly converts paths to slash here, which then is passed to the error message. The error message on windows tests expect backslash separators, where the code always returns slash. We can change the tests or the code to comply; the question is which one is intended behaviour? |
Is there any reason not to use the |
Not that I can think of. |
This is definitely a bug. We convert to "unix" paths for IPFS, but these should just be normal windows paths: #214 |
6d19059
to
1c3bb01
Compare
1c3bb01
to
40e92d7
Compare
Syncing to commit protocol/.github@928c600.