-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MaxLinks for requests #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. Is there any reason we shouldn't support this ALSO on the other side (i.e. IncomingRequestHookActions)?
That way the data transfer PR can be for Pushes too.
Added support for incoming and outgoing hook configuration of MaxLinks. Also added tests. |
d40f493
to
d23335b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: use traversal link budget instead of limitstore Ref: ipfs/go-graphsync#420 Ref: filecoin-project/go-data-transfer#374 * chore(deps): update go-data-transfer v2.0.0-rc7 * style(lint): fix fmt --------- Co-authored-by: hannahhoward <[email protected]>
Per-request MaxLinks option.
Only for requests currently. No tests yet. Further discussions in Lassie, follow-up PR there and in go-data-transfer.