fixup! feat: add basic OT tracing for incoming requests

ipfs · Nov 25, 2021 · f89b9a8 · f89b9a8
1 parent 2e721a3
commit f89b9a8
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/impl/graphsync_test.go b/impl/graphsync_test.go
@@ -89,8 +89,9 @@ func TestMakeRequestToNetwork(t *testing.T) {
 	require.Equal(t, td.extensionData, returnedData, "Failed to encode extension")
 
 	tracing := collectTracing(t)
-	// single, incomplete trace expected, we stop short of executing the request
-	require.ElementsMatch(t, []string{"request->newRequest"}, tracing.TracesToStrings())
+	// single trace expected, likely incomplete but but the executor may slip in and begin executing before end of test
+	traces := tracing.TracesToStrings()
+	require.True(t, reflect.DeepEqual([]string{"request->newRequest"}, traces) || reflect.DeepEqual([]string{"request->newRequest->executeTask"}, traces))
 
 	// make sure the attributes are what we expect
 	requestSpans := tracing.FindSpans("request")