Implement maintenance methods #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
approved these changes
Jan 13, 2018
|
|
||
| func (m *measure) CollectGarbage() error { | ||
| defer recordLatency(m.gcLatency, time.Now()) | ||
| m.gcNum.Inc() |
There was a problem hiding this comment.
Shouldn't we only modify the metrics if we actually do a GC? That is, shouldn't these go inside the condition?
There was a problem hiding this comment.
The count metrics are described as Total number of Datastore.[..] calls, so my reasoning was that we want to count number of method invocations, not what they are actually doing.
magik6k
force-pushed
the
feat/maintenance-methods
branch
from
7a90d29 to
fa0f7cf
Compare
|
Rebased, merging to avoid further conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.