This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
fix: Improve types and follow the specs #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guseggert
reviewed
Nov 28, 2022
- Organize types in its own package and clean duplicated objects - Add prefix `/routing` on urls - Fix bitswap provide response to use a Duration type - Fix provideResults output to only return a list with all the providers instead of a list of provider names plus a list of providers objects. Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
ajnavarro/simplify-types
branch
from
40b427a to
4e5c7a0
Compare
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
guseggert
added a commit
to ipfs/boxo
that referenced
this pull request
Nov 29, 2022
* Organize types in their own package and clean duplicated objects * Add prefix /routing on URLs * Fix bitswap provide response to use a Duration type * Fix provideResults output to only return a list with all the providers * instead of a list of provider names plus a list of provider objects. This code was moved from ipfs/go-delegated-routing#66
|
Superseded by ipfs/boxo#5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #65
/routingon URLsinstead of a list of provider names plus a list of provider objects.
Signed-off-by: Antonio Navarro Perez [email protected]