Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Fix: Handle correctly keys on Get/Put Value and Get/Put IPNS. #31

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

ajnavarro
Copy link
Member

No description provided.

client/store.go Outdated Show resolved Hide resolved
client/getipns.go Outdated Show resolved Hide resolved
client/store.go Show resolved Hide resolved
@ajnavarro ajnavarro force-pushed the fix/value-storage branch 2 times, most recently from cb7f397 to ab4e2c2 Compare July 7, 2022 08:09
@ajnavarro
Copy link
Member Author

Tests will stop failing after merging: #28

@ajnavarro ajnavarro force-pushed the fix/value-storage branch from ab4e2c2 to db21c1c Compare July 7, 2022 09:55
@BigLep
Copy link

BigLep commented Jul 7, 2022

2022-07-07 conversation: in review, focus on making sure we're handling strings properly.

client/putipns.go Outdated Show resolved Hide resolved
@ajnavarro ajnavarro force-pushed the fix/value-storage branch from a20a73a to 9153e54 Compare July 7, 2022 17:32
@ajnavarro ajnavarro requested a review from aschmahmann July 7, 2022 17:51
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

client/putipns.go Outdated Show resolved Hide resolved
client/putipns.go Outdated Show resolved Hide resolved
client/store.go Outdated Show resolved Hide resolved
client/store.go Outdated Show resolved Hide resolved
client/store.go Outdated Show resolved Hide resolved
@ajnavarro ajnavarro force-pushed the fix/value-storage branch from 7724466 to 0136a56 Compare July 7, 2022 18:20
@ajnavarro ajnavarro force-pushed the fix/value-storage branch from cc1e7a4 to 5d654e8 Compare July 7, 2022 18:28
@ajnavarro ajnavarro force-pushed the fix/value-storage branch from 5d654e8 to 688ceea Compare July 7, 2022 18:29
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jorropo Jorropo merged commit b49eeb1 into ipfs:main Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants