Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a utility method for sorting CID slices #5

Merged
merged 1 commit into from
Sep 24, 2018
Merged

add a utility method for sorting CID slices #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions slice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package cidutil

import (
"github.com/ipfs/go-cid"
"sort"
)

// Slice is a convenience type for sorting CIDs
type Slice []cid.Cid

func (s Slice) Len() int {
return len(s)
}

func (s Slice) Less(i, j int) bool {
return s[i].KeyString() < s[j].KeyString()
}

func (s Slice) Swap(i, j int) {
s[i], s[j] = s[j], s[i]
}

func (s Slice) Sort() {
sort.Sort(s)
}

// Sort sorts a slice of CIDs
func Sort(s []cid.Cid) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not wrap either sort.Slice or sort.SliceStable and then the Slice type isn't required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort.Slice uses reflection so it's not quite as fast. It may not make a difference but it's not exactly a ton of code.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, this may just be me having an aversion to named slice types more than anything else :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well... when go introduces proper generics all this stuff will magically disappear. Until then, we have hand-coded monomorphization.

😞

Slice(s).Sort()
}