Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding blake3 support, bumping versions #140

Closed
wants to merge 1 commit into from

Conversation

laudiacay
Copy link

adding blake3 stuff and bumping multihash version. bumping minor version here too.

@welcome
Copy link

welcome bot commented Jul 1, 2022

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@laudiacay
Copy link
Author

depends on this getting merged: multiformats/go-multihash#158

@laudiacay laudiacay mentioned this pull request Jul 1, 2022
3 tasks
@laudiacay laudiacay marked this pull request as ready for review July 1, 2022 00:32
@Jorropo
Copy link
Contributor

Jorropo commented Jul 1, 2022

Golang's dependency model is not tree like.

Except counting /v2, /v3, ... branches (which we are not using here). Only one version of the package is compiled (the latest one).

If a consumer (like go-ipfs) updates to a later go-multihash this also updates it for all other users of this module (like go-cid).

I think this can be closed, if someone need some custom go-multihash for some blake3 thing they can just update to the newer go-multihash.

@laudiacay
Copy link
Author

phew one less to worry about.... so i guess we just need to bump go-verifcid on go-ipfs, and get the go-multihash bugfix in.

@laudiacay laudiacay closed this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants