This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Avoid allocating a session unless we need it #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
whyrusleeping
force-pushed
the
feat/avoid-alloc-sess
branch
from
0aab3f1 to
923ada9
Compare
whyrusleeping
force-pushed
the
feat/avoid-alloc-sess
branch
from
923ada9 to
8819f05
Compare
Stebalien
approved these changes
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago we tried using sessions for the gateways fetching code. It killed our memory usage, as we were allocating a session for every single little fetch, even if we already had it cached locally.
Sessions will still take a solid hunk of memory, and we should work to address that separately, but this should help.