Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

make the WantlistManager own the PeerHandler #78

Merged
merged 1 commit into from
Apr 29, 2019
Merged

make the WantlistManager own the PeerHandler #78

merged 1 commit into from
Apr 29, 2019

Conversation

Stebalien
Copy link
Member

And remove all locks.

@ghost ghost assigned Stebalien Feb 20, 2019
@ghost ghost added the status/in-progress In progress label Feb 20, 2019
@hannahhoward hannahhoward force-pushed the feat/differentiate_wantList branch from 1a12448 to eb192a0 Compare February 20, 2019 23:00
@Stebalien Stebalien force-pushed the feat/differentiate_wantList branch from eb192a0 to 60371f7 Compare February 20, 2019 23:10
@hannahhoward hannahhoward force-pushed the feat/differentiate_wantList branch 2 times, most recently from b51c20e to 95f6e62 Compare February 20, 2019 23:15
@Stebalien Stebalien changed the base branch from feat/differentiate_wantList to master February 20, 2019 23:26
@Stebalien Stebalien requested a review from hannahhoward April 26, 2019 00:25
@Stebalien
Copy link
Member Author

@hannahhoward how do you feel about this change?

@Stebalien Stebalien changed the title [RFC] make the WantlistManager own the PeerHandler make the WantlistManager own the PeerHandler Apr 26, 2019
hannahhoward
hannahhoward approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why I thought maybe this wouldn't work? But I agree-- if nothing else at all owns the peer manager, let's have the want manager own it and use that to drop the locks.

So, I guess, LGTM.

@Stebalien Stebalien merged commit 401b87d into master Apr 29, 2019
@Stebalien Stebalien deleted the fix/lockless branch April 29, 2019 21:46
@ghost ghost removed the status/in-progress In progress label Apr 29, 2019
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
@Stebalien
Merge pull request ipfs/go-bitswap#78 from ipfs/fix/lockless
1d30b5b 
make the WantlistManager own the PeerHandler

This commit was moved from ipfs/go-bitswap@401b87d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @hannahhoward