Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

fix(tests): stabilize session tests #63

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Conversation

hannahhoward
Copy link
Contributor

@hannahhoward hannahhoward commented Jan 24, 2019

Goals

Improve stability of tests for Session and SessionPeerManager so that CI consistently passes

Implementation

Basically, tests of concurrent code is hard. Definitely don't want to deadlock, and also, want to make sure synchronization is correct so that work is always done before results are tests

With that in mind:

For Discussion

fix #61

@ghost ghost assigned hannahhoward Jan 24, 2019
@ghost ghost added the status/in-progress In progress label Jan 24, 2019
@hannahhoward hannahhoward force-pushed the feat/stabilize-tests branch 6 times, most recently from 546ad70 to 01929dd Compare January 26, 2019 00:13
Improve stability of tests for Session and SessionPeerManager

fix #61
@hannahhoward hannahhoward merged commit b2ed484 into master Jan 30, 2019
@ghost ghost removed the status/in-progress In progress label Jan 30, 2019
Jorropo pushed a commit to Jorropo/go-libipfs that referenced this pull request Jan 26, 2023
fix(tests): stabilize session tests

This commit was moved from ipfs/go-bitswap@b2ed484
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are unreliable
2 participants