This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
feat: refactor message receiving code #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
commented
Jun 5, 2020
dirkmc
approved these changes
Jun 8, 2020
|
Any reason not to merge? (I see it's a draft PR) |
Stebalien
added a commit
that referenced
this pull request
Jun 8, 2020
Quick alternative to #407 to fix the main issue.
dirkmc
pushed a commit
that referenced
this pull request
Jun 8, 2020
Quick alternative to #407 to fix the main issue.
I wanted to get in a quick fix first for the release. I left it as a draft due to that last question. |
The primary motivation for this was to only account for _wanted_ blocks in the engine. This change also untangles some code, fixes some todos, and avoids reusing `receiveBlocksFrom` for processing _local_ blocks.
Stebalien
force-pushed
the
refactor/receive-message
branch
from
814ce68 to
30b442e
Compare
Stebalien
commented
Jun 10, 2020
| // Record how many bytes were received in the ledger | ||
| for _, block := range blks { | ||
| log.Debugw("Bitswap engine <- block", "local", e.self, "from", p, "cid", block.Cid(), "size", len(block.RawData())) | ||
| l.ReceivedBytes(len(block.RawData())) |
There was a problem hiding this comment.
We should probably just replace this with some form of l.ReceivedBlocks(...) and l.SentBlocks(...). But we can do that later.
|
Let's wait until we get #413 fixed before merging this (so we don't have to fork a patch release branch). |
|
This repository has been moved to https://github.com/ipfs/go-libipfs. There is not an easy way to transfer PRs, so if you would like to continue with this PR then please re-open it in the new repository and link to this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation for this was to only account for wanted blocks in the engine.
This change also untangles some code, fixes some todos, and avoids reusing
receiveBlocksFromfor processing local blocks.