This repository has been archived by the owner on Feb 1, 2023. It is now read-only.
Total wants gauge #402
Merged
Total wants gauge #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we track number of wants instead of number of wants per peer? I'm looking to see "how many different things are we trying to download". This gives us a good metric on how "loaded" a machine is. |
Stebalien
approved these changes
Jun 1, 2020
| @@ -207,6 +238,9 @@ func (pwm *peerWantManager) sendCancels(cancelKs []cid.Cid) { | |||
| } | |||
There was a problem hiding this comment.
We should be able to simplify all of this to:
(and remove the sets)
if pwm.broadcastWants.Has(c) {
broadcastCancels = append(broadcastCancels, c)
pwm.wantGague.Dec()
} else if _, ok := pwm.wantPeers[c]; ok {
pwm.wantGague.Dec()
}There was a problem hiding this comment.
The problem is that we need to decrement the want-block gauge as well as the all-wants gauge, and we don't know if pwm.wantPeers[c] points to a want-have or a want-block.
There was a problem hiding this comment.
Ah, I see. Eh, then we can profile later to see if it makes a difference.
Stebalien
approved these changes
Jun 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #333
Currently we track the number of pending want-blocks in
wantlist_total.In this PR
wantlist_totalis the total number of pending want-blocks + want-haveswant_blocks_totalis the total number of pending want-blocks