Bitswap Refactor #1: Session Manager & Extract Want Manager #28
Conversation
ghost
assigned 
hannahhoward
changed the title
sessionmanager/sessionmanager.go
Outdated
|
|
||
| type IterateSessionFunc func(session exchange.Fetcher) | ||
|
|
||
| // SessionsForBlock returns a slice of all sessions that may be interested in the given cid |
| var out []*Session | ||
| for _, s := range bs.sessions { | ||
| bs.sm.IterateSessions(func(session exchange.Fetcher) { | ||
| s := session.(*Session) |
There was a problem hiding this comment.
Having this cast is a bit funky. I get that this is to avoid a dependency issue but I wonder if there's a better way. Would it make sense to move sessions into their own package? That way, SessionManager could operate over concrete sessions.
Unfortunately, I don't think that'll work as Session appears to need access to bitswap internals. An alternative is to create a Session interface that exposes an InterestedIn method.
I'd be fine punting these questions till later.
There was a problem hiding this comment.
Hey!
Let's punt till later since two PR's forward Sessions end up in their own package, and this cast is gone :)
|
IterateSessions disappears in a later PR so I wouldn't worry to much about it. I will fix the comment issue though. |
Extract session manager from bitswap Extract session manager & want manager to package Move want manager message queue to seperate file Move Message Queue to subpackage Respond to PR Comments
hannahhoward
force-pushed
the
feat/extract-to-package
branch
from
4d5134c to
69d063b
Compare
|
This is mostly just moving code around so I'm going to leave it at one LGTM. |
|
continues in #29 |
Bitswap Refactor ipfs#1: Session Manager & Extract Want Manager This commit was moved from ipfs/go-bitswap@c9fee08
Goals
Modularize Bitswap in preparation for attempts to optimize bitswap further
child of #26
Implementation