Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

Make internals internal #238

Closed
Stebalien opened this issue Jan 21, 2020 · 2 comments · Fixed by #242
Closed

Make internals internal #238

Stebalien opened this issue Jan 21, 2020 · 2 comments · Fixed by #242

Comments

@Stebalien
Copy link
Member

We have a lot of internal components that aren't reusable outside this package. We should put them in an internal package.

Proposal: Move everything except the main package, network, wantlist, and message to an internal package.

(let's wait for the refactor to do this)
@dirkmc
Copy link
Contributor

dirkmc commented Jan 21, 2020

Sounds good 👍

When you say wait for the refactor, you mean do it after we've merged the proof of concept branch?

@Stebalien
Copy link
Member Author

Yes. I've been slowly marking files in that patch as "seen" so moving things around would be really unfortunate...

Stebalien added a commit that referenced this issue Jan 30, 2020
@Stebalien
feat: move internals to an internal package
bbf6529 
This makes reading the docs much easier as it's clear what's "private" and
what's not.

fixes #238
@Stebalien Stebalien mentioned this issue Jan 30, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: move internals to an internal package ipfs/go-bitswap
2 participants
@dirkmc @Stebalien