Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: IPFS Rust Phase 2 #47

Merged
merged 5 commits into from May 20, 2020
Merged

proposal: IPFS Rust Phase 2 #47

merged 5 commits into from May 20, 2020

Conversation

aphelionz
Copy link
Contributor

@aphelionz aphelionz commented Apr 21, 2020

The goal of the Rust IPFS Phase 1 devgrant was to allow developers to write IPLD applications. Since the approval and inception of the grant work in Q1 2020, the grant team has delivered a Rust implementation with over a dozen HTTP endpoints and over 100 passing conformance tests.

As such, we believe that IPLD application developers have what they need to start creating apps that leverage the flexibility and connectivity of IPLD, along with the performance and reliability of Rust.

Two of the pillars for a ready-to-use implementation of IPFS are there now: peer-to-peer networking and the blockstore. What remains is UnixFS. This proposal is a small fast-follow to Phase 1, which completes the foundation and provides something that can be tested in the wild.

Full text

Mark Henderson and others added 3 commits April 21, 2020 18:11
Adding phase 2

Phase 2 updates

fix: formatting

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

chore: merging in remote

Rough draft

Added Lukasz, removed detritus

Update README.md

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

review updates

Updates after reading out loud

small styling update

Quick edits

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

removing guarantees to publication, adding orbitdb

adding note about /key endpoint

removing cargo install

proposal: IPFS Rust Phase 2

Adding phase 2

Phase 2 updates

fix: formatting

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

chore: merging in remote

Rough draft

Added Lukasz, removed detritus

Update README.md

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

review updates

Updates after reading out loud

small styling update

Quick edits

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

Update open-grants/ipfs-rust/phase-2/README.md

Co-Authored-By: Joonas Koivunen <[email protected]>

removing guarantees to publication, adding orbitdb

adding note about /key endpoint

removing cargo install

fixing prices
@aphelionz
Copy link
Contributor Author

@momack2 Scoped down and edited the description and link above

@parkan parkan mentioned this pull request Apr 28, 2020
@momack2 momack2 added the type:open-grant Open Grant Tracking (https://github.com/protocol/ipfs-grants/blob/master/open-grants/README.md) label May 1, 2020
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline comment about tests.

open-grants/ipfs-rust/phase-2/README.md Show resolved Hide resolved
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I somehow cannot resolve my comment about the test coverage. Consider it resolved with my approval of this PR.

@aphelionz
Copy link
Contributor Author

@hugomrdias might you be able to lay out some of the feedback you provided on Matrix here?

* remove embedded settings

having discussed this internally we would like to withdraw this word as
it might allude to `no_std` for targets without an operating system.

* fix links ipfs-rust => rs-ipfs

following organization change.

* remove references to /ls

following feedback we decided not to pursue /ls endpoint.

* Update open-grants/ipfs-rust/phase-2/README.md

* add future roadmapping or planning

* add explanation for leaving the importer side

* Update README.md

Co-authored-by: Mark Robert Henderson <[email protected]>
@aphelionz
Copy link
Contributor Author

@hugomrdias @momack2 Made the requested updates + clarifications based on Hugo's conversations and feedback!

@momack2
Copy link
Collaborator

momack2 commented May 15, 2020

Awesome! Thanks for the tweaks and edits - this LGTM to me! Thanks to @hugomrdias for the review and tweaks.

@parkan can you help manage the disbursement here?

@parkan parkan self-assigned this May 16, 2020
@momack2 momack2 merged commit d029262 into ipfs:master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:open-grant Open Grant Tracking (https://github.com/protocol/ipfs-grants/blob/master/open-grants/README.md)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants