-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not send cancel message to peer that sent block #784
Conversation
The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block. Closes #694
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #784 +/- ##
==========================================
+ Coverage 60.50% 60.52% +0.02%
==========================================
Files 245 245
Lines 31138 31139 +1
==========================================
+ Hits 18840 18847 +7
+ Misses 10620 10618 -2
+ Partials 1678 1674 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we are sure that we have not requested the same CIDs to the same peer via some other session etc. right?
My main worry would be we start leaking something.
PeerManager also takes care of deduplication if multiple session want the same data |
The serving peer cleans the client's wantlint after serving the block, making sending CANCEL to the serving peer redundant. So, exclude the serving peer when sending cancels after receiving a block.
Closes #694