Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitswap): log unexpected blocks to debug level #711

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(bitswap): log unexpected blocks to debug level #711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@ The following emojis are used to highlight certain changes:

### Changed

- updated to go-libp2p to [v0.37.0](https://github.com/libp2p/go-libp2p/releases/tag/v0.37.0)

### Removed

### Fixed

- Fix panic if current live count is greater than broadcast limit [#702](https://github.com/ipfs/boxo/pull/702)
- `bitswap/client` no longer logs `"Received provider X for cid Y not requested` to ERROR level, moved to DEBUG [#771](https://github.com/ipfs/boxo/pull/711)

### Security

## [v0.24.2]
Expand Down
2 changes: 1 addition & 1 deletion bitswap/client/internal/providerquerymanager/providerquerymanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@
func (rpm *receivedProviderMessage) handle(pqm *ProviderQueryManager) {
requestStatus, ok := pqm.inProgressRequestStatuses[rpm.k]
if !ok {
log.Errorf("Received provider (%s) for cid (%s) not requested", rpm.p.String(), rpm.k.String())
log.Debugf("Received provider (%s) for cid (%s) not requested", rpm.p.String(), rpm.k.String())

Check warning on line 358 in bitswap/client/internal/providerquerymanager/providerquerymanager.go

View check run for this annotation

Codecov / codecov/patch

bitswap/client/internal/providerquerymanager/providerquerymanager.go#L358 

Added line #L358 was not covered by tests
return
}
requestStatus.providersSoFar = append(requestStatus.providersSoFar, rpm.p)
Expand Down