fix(routing/http/contentrouter): additional FindPeer checks #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 59.75% 59.79% +0.03%
==========================================
Files 238 238
Lines 29979 29984 +5
==========================================
+ Hits 17914 17928 +14
+ Misses 10446 10434 -12
- Partials 1619 1622 +3
|
aschmahmann
force-pushed
the
fix/httpfindpeer
branch
from
aa235ae to
729ba99
Compare
aschmahmann
force-pushed
the
fix/httpfindpeer
branch
from
729ba99 to
6898608
Compare
gammazero
approved these changes
Jun 19, 2024
… that matches the requested peerID
… if there are actual addresses
…here there aren't key pairs
aschmahmann
force-pushed
the
fix/httpfindpeer
branch
from
6badb35 to
558123e
Compare
lidel
approved these changes
Jun 20, 2024
lidel
changed the title
wenyue
pushed a commit
to wenyue/boxo
that referenced
this pull request
Oct 17, 2024
* fix(routing/http/contentrouter): return error when no responses are found in FindPeer * fix(routing/http/contentrouter): fix findpeer iteration log message * fix(routing/http/contentrouter): only return information for FindPeer that matches the requested peerID * fix(routing/http/contentrouter): only return information for FindPeer if there are actual addresses * fix(routing/http/contentrouter): switch logging from Warnw -> Warnf where there aren't key pairs * docs: update CHANGELOG.md --------- Co-authored-by: Marcin Rataj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a few issues while doing some tracing (e.g. errors not being returned when no data was returned) that caused me to look a little closer here.