Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipfs/go-bitswap] Make Bitswap protocol Resource Manager aware #66

Open
3 tasks
ajnavarro opened this issue Jan 24, 2023 · 0 comments
Open
3 tasks

[ipfs/go-bitswap] Make Bitswap protocol Resource Manager aware #66

ajnavarro opened this issue Jan 24, 2023 · 0 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@ajnavarro
Copy link
Member

We have to make bitswap protocol RM aware to make good use of resources and retry or error when an RM error is returned from any call to libp2p.

  • Do not fire and forget. Always handle errors
  • Add sane limits to some of bitswap operations. Example: do not allow to respond to requests of hundred of thousand CIDs.
  • Check for RM errors and retry if needed.
@ajnavarro ajnavarro added the need/triage Needs initial labeling and prioritization label Jan 24, 2023
@ajnavarro ajnavarro mentioned this issue Jan 24, 2023
Closed
1 task
@ipfs ipfs deleted a comment from welcome bot Jan 26, 2023
@Jorropo Jorropo changed the title Make Bitswap protocol Resource Manager aware [ipfs/go-bitswap] Make Bitswap protocol Resource Manager aware Jan 27, 2023
@Jorropo Jorropo transferred this issue from ipfs/go-bitswap Jan 27, 2023
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this issue Mar 23, 2023
@hacdias
feat: expose ErrInvalidPath and implement .Is function (ipfs#66)
cd0d3b1 


This commit was moved from ipfs/go-path@6793198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajnavarro