util: use subtle for XORing bytes

Fixes #377
ipfs · Jun 26, 2023 · 4e151f6 · 4e151f6
1 parent 290613a
commit 4e151f6
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/util/util.go b/util/util.go
@@ -3,6 +3,7 @@
 package util
 
 import (
+	"crypto/subtle"
 	"errors"
 	"io"
 	"math/rand"
@@ -150,9 +151,11 @@ func IsValidHash(s string) bool {
 
 // XOR takes two byte slices, XORs them together, returns the resulting slice.
 func XOR(a, b []byte) []byte {
-	c := make([]byte, len(a))
-	for i := 0; i < len(a); i++ {
-		c[i] = a[i] ^ b[i]
+	if len(a) != len(b) {
+		panic("unmatched slices lengths")
 	}
+
+	c := make([]byte, len(a))
+	subtle.XORBytes(c, a, b)
 	return c
 }