Normalize path separator in tests based in OS

Use OS specific path separators in tests This commit was moved from ipfs/go-ipfs-files@ac10fa8
ipfs · Jul 22, 2021 · 302094f · 302094f
1 parent ecef908
commit 302094f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 22 deletions.
diff --git a/files/filewriter_test.go b/files/filewriter_test.go
@@ -24,20 +24,20 @@ func TestWriteTo(t *testing.T) {
 	}
 	defer os.RemoveAll(tmppath)
 
-	path := tmppath + "/output"
+	path := filepath.Join(tmppath, "output")
 
 	err = WriteTo(sf, path)
 	if err != nil {
 		t.Fatal(err)
 	}
 	expected := map[string]string{
-		".":   "",
-		"1":   "Some text!\n",
-		"2":   "beep",
-		"3":   "",
-		"4":   "boop",
-		"5":   "",
-		"5/a": "foobar",
+		".":                       "",
+		"1":                       "Some text!\n",
+		"2":                       "beep",
+		"3":                       "",
+		"4":                       "boop",
+		"5":                       "",
+		filepath.FromSlash("5/a"): "foobar",
 	}
 	err = filepath.Walk(path, func(cpath string, info os.FileInfo, err error) error {
 		if err != nil {

diff --git a/files/serialfile_test.go b/files/serialfile_test.go
@@ -29,27 +29,27 @@ func testSerialFile(t *testing.T, hidden, withIgnoreRules bool) {
 	defer os.RemoveAll(tmppath)
 
 	testInputs := map[string]string{
-		"1":      "Some text!\n",
-		"2":      "beep",
-		"3":      "",
-		"4":      "boop",
-		"5":      "",
-		"5/a":    "foobar",
-		".6":     "thing",
-		"7":      "",
-		"7/.foo": "bla",
-		".8":     "",
-		".8/foo": "bla",
+		"1":                          "Some text!\n",
+		"2":                          "beep",
+		"3":                          "",
+		"4":                          "boop",
+		"5":                          "",
+		filepath.FromSlash("5/a"):    "foobar",
+		".6":                         "thing",
+		"7":                          "",
+		filepath.FromSlash("7/.foo"): "bla",
+		".8":                         "",
+		filepath.FromSlash(".8/foo"): "bla",
 	}
 	fileFilter, err := NewFilter("", []string{"9", "10"}, hidden)
 	if err != nil {
 		t.Fatal(err)
 	}
 	if withIgnoreRules {
 		testInputs["9"] = ""
-		testInputs["9/b"] = "bebop"
+		testInputs[filepath.FromSlash("9/b")] = "bebop"
 		testInputs["10"] = ""
-		testInputs["10/.c"] = "doowop"
+		testInputs[filepath.FromSlash("10/.c")] = "doowop"
 	}
 
 	for p, c := range testInputs {
@@ -76,7 +76,7 @@ func testSerialFile(t *testing.T, hidden, withIgnoreRules bool) {
 
 testInputs:
 	for p := range testInputs {
-		components := strings.Split(p, "/")
+		components := strings.Split(p, string(filepath.Separator))
 		var stat os.FileInfo
 		for i := range components {
 			stat, err = os.Stat(filepath.Join(