-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: move to travis #324
ci: move to travis #324
Conversation
windows still fails in same runners because of the line endings issue. but you can see the branch run is green 🚀 |
This problem will most likely go away after the merge! Do we really need the two runs that Travis does ? one for the branch and another for the PR (runs the tests on the merge commit between HEAD branch and target branch). |
What about the codecov drops? |
it's on the travis.yml file no need to have more coverage stuff in aegir it self i'll probably add more docs on how to check coverage locally @daviddias so we really need to have both builds active on travis? can we live with only PRs? |
I didn’t understand this.
Let’s paint that bike shed in another thread :) Open a issue on ipfs/js-core |
we still have coverage and codecov service reporting it but only in the travis config, i removed the aegir coverage cmd because it didn't added much value. I'll improve the docs around this to be easier to understand. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
squash and merge :)
put it on a ⛵️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR adds